[9.1.0] Allow --test_env / env= to override coverage env (https://github.com/bazelbuild/bazel/pull/29110)#29169
Merged
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from Mar 31, 2026
Conversation
Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes bazelbuild#23247 Closes bazelbuild#29110. PiperOrigin-RevId: 892333567 Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c
bazel-io
added
team-Configurability
gregestren
approved these changes
Mar 31, 2026
gregestren
added
awaiting-PR-merge
Merged
via the queue into
bazelbuild:release-9.1.0
with commit Mar 31, 2026
c471751
46 checks passed
github-actions
Bot
removed
the
awaiting-PR-merge
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 20, 2026
- Update Bazel, this includes several performance/memory usage improvements. Release notes: https://github.com/bazelbuild/bazel/releases/tag/9.1.0 - Do not mark weakref test as flaky – the test is evidently not flaky in workerd where we don't re-run tests, and having any tests marked as flaky in workerd can slow down internal CI runs that will have to fetch workerd even if they only need to run tests in the flaky cordon - Simplify coverage configuration – based on a close look at the rules_cc and bazel repos, we define several things more than once, we can remove some coverage overrides in .bazelrc. The additional tests added in bazelbuild/bazel#29169 were helpful in better understanding this. - Update pnpm/action-setup to a version based on Node22 to avoid Node20 deprecation warnings - Remove obsolete typescript hash definition - Adjust bazelmod mangled paths to facilitate internal changes
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 20, 2026
- Update Bazel, this includes several performance/memory usage improvements. Release notes: https://github.com/bazelbuild/bazel/releases/tag/9.1.0 - Do not mark weakref test as flaky – the test is evidently not flaky in workerd where we don't re-run tests, and having any tests marked as flaky in workerd can slow down internal CI runs that will have to fetch workerd even if they only need to run tests in the flaky cordon - Simplify coverage configuration – based on a close look at the rules_cc and bazel repos, we define several things more than once, we can remove some coverage overrides in .bazelrc. The additional tests added in bazelbuild/bazel#29169 were helpful in better understanding this. - Update pnpm/action-setup to a version based on Node22 to avoid Node20 deprecation warnings - Remove obsolete typescript hash definition - Adjust bazelmod mangled paths to facilitate internal changes
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 21, 2026
- Update Bazel, this includes several performance/memory usage improvements. Release notes: https://github.com/bazelbuild/bazel/releases/tag/9.1.0 - Do not mark weakref test as flaky – the test is evidently not flaky in workerd where we don't re-run tests, and having any tests marked as flaky in workerd can slow down internal CI runs that will have to fetch workerd even if they only need to run tests in the flaky cordon - Simplify coverage configuration – based on a close look at the rules_cc and bazel repos, we define several things more than once, we can remove some coverage overrides in .bazelrc. The additional tests added in bazelbuild/bazel#29169 were helpful in better understanding this. - Update pnpm/action-setup to a version based on Node22 to avoid Node20 deprecation warnings - Remove obsolete typescript hash definition - Adjust bazelmod mangled paths to facilitate internal changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel sets some environment variables for CC coverage collection that
can be useful to override in some projects. Previously this was possible
but as a side effect of 87b0a1f it
stopped working. This re-enables that and covers it in tests
Fixes #23247
Closes #29110.
PiperOrigin-RevId: 892333567
Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c
Commit 15e078b