[build] Update to Bazel 9.1.0, perform build cleanup#6622
Merged
Conversation
Contributor
|
All the changes look clean and straightforward. Let me verify there's nothing else I should check — specifically, that the The diff is clean. Let me summarize my findings:
None of these changes introduce logic bugs, security issues, backward compatibility violations, or other actionable problems. All changes are build/CI configuration — no runtime code is affected. LGTM |
c05b200 to
22d5545
Compare
22d5545 to
5990f77
Compare
npaun
approved these changes
Apr 20, 2026
mikea
approved these changes
Apr 20, 2026
- Update Bazel, this includes several performance/memory usage improvements. Release notes: https://github.com/bazelbuild/bazel/releases/tag/9.1.0 - Do not mark weakref test as flaky – the test is evidently not flaky in workerd where we don't re-run tests, and having any tests marked as flaky in workerd can slow down internal CI runs that will have to fetch workerd even if they only need to run tests in the flaky cordon - Simplify coverage configuration – based on a close look at the rules_cc and bazel repos, we define several things more than once, we can remove some coverage overrides in .bazelrc. The additional tests added in bazelbuild/bazel#29169 were helpful in better understanding this. - Update pnpm/action-setup to a version based on Node22 to avoid Node20 deprecation warnings - Remove obsolete typescript hash definition - Adjust bazelmod mangled paths to facilitate internal changes
5990f77 to
85f83ee
Compare
jasnell
approved these changes
Apr 21, 2026
edmundhung
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also see the downstream PR.
Reviewers: Convince yourself that the coverage percentage is unchanged (see report in https://app.codecov.io/github/cloudflare/workerd/commit/c05b200a01ce30d0c39ba40c7c6d0ed30cd9b2de) and look at the internal changes for context.