Don't consider external repos dirty if hardlink count changes - #29701
Closed
fmeum wants to merge 2 commits into
Closed
Don't consider external repos dirty if hardlink count changes#29701fmeum wants to merge 2 commits into
fmeum wants to merge 2 commits into
Conversation
fmeum
force-pushed
the
29590-mtime-refetch
branch
from
June 1, 2026 20:11
c085db0 to
85e5776
Compare
fmeum
changed the title
fmeum
marked this pull request as ready for review
June 1, 2026 20:13
github-actions
Bot
added
team-Performance
Collaborator
Author
|
@bazel-io fork 9.2.0 |
Wyverald
approved these changes
Jun 16, 2026
Wyverald
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
bazel-io
added a commit
to bazel-io/bazel
that referenced
this pull request
Jun 23, 2026
…bazelbuild#29701) (bazelbuild#29889) ### Description When checking external repos for external modifications, don't use ctime as it is sensitive to hardlink count changes (e.g. with `--experimental_use_hermetic_linux_sandbox`) and thus causes false positives. ### Motivation Fixes bazelbuild#29590 ### Build API Changes No ### Checklist - [x] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes RELNOTES: External repos are no longer refetched whenever they contribute inputs to an action using the hermetic Linux sandbox. Closes bazelbuild#29701. PiperOrigin-RevId: 934309229 Change-Id: I22aa96959047496f5b71234cd2363ca98619a903 Commit bazelbuild@57b14c4 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When checking external repos for external modifications, don't use ctime as it is sensitive to hardlink count changes (e.g. with
--experimental_use_hermetic_linux_sandbox) and thus causes false positives.Motivation
Fixes #29590
Build API Changes
No
Checklist
Release Notes
RELNOTES: External repos are no longer refetched whenever they contribute inputs to an action using the hermetic Linux sandbox.