Skip to content

Remove --incompatible_do_not_split_linking_cmdline#29931

Open
dzbarsky wants to merge 1 commit into
bazelbuild:masterfrom
dzbarsky:codex/remove-do-not-split-linking-cmdline
Open

Remove --incompatible_do_not_split_linking_cmdline#29931
dzbarsky wants to merge 1 commit into
bazelbuild:masterfrom
dzbarsky:codex/remove-do-not-split-linking-cmdline

Conversation

@dzbarsky

Copy link
Copy Markdown
Contributor

--incompatible_do_not_split_linking_cmdline was introduced disabled in March 2019 by 3010e57805 to migrate C++ linking away from GCC-specific command-line splitting; #7670 and #7687 tracked the migration. It was enabled by default in May 2019 by 28c8a8c91f. The conditional implementation and legacy behavior were removed in February 2021 by 4d75da6323, leaving the option with no consumer beyond Starlark semantics bookkeeping.

This removes the option, semantics key, and consistency-test rows.

Validation: bazel test --jobs=4 --disk_cache=/private/tmp/bazel-pr-disk-cache //src/test/java/com/google/devtools/build/lib/packages/semantics:ConsistencyTest.

The flag was introduced disabled in March 2019 by 3010e57 to migrate C++ linking away from GCC-specific command-line splitting. It was enabled by default in May 2019 by 28c8a8c. The conditional implementation and legacy behavior were removed in February 2021 by 4d75da6, leaving only Starlark semantics bookkeeping.

Remove the option, semantics key, and consistency-test rows.

RELNOTES: Remove the no-op --incompatible_do_not_split_linking_cmdline flag.
@dzbarsky dzbarsky marked this pull request as ready for review June 22, 2026 15:23
@github-actions github-actions Bot added awaiting-review PR is awaiting review from an assigned reviewer team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob labels Jun 22, 2026
@github-actions github-actions Bot added the community-reviewed Reviewed by a trusted community contributor label Jun 22, 2026
@meisterT meisterT requested a review from pzembrod June 25, 2026 07:26
@tetromino tetromino added the awaiting-internal-cleanup The PR cannot be merged, because that would be incompatible internally at Google. label Jul 9, 2026
@tetromino

tetromino commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

For some reason --incompatible_do_not_split_linking_cmdline is explicitly enabled by default in google monorepo, needs to be cleaned up first (should be trivial)

verdeving pushed a commit to verdeving/carbon-lang that referenced this pull request Jul 14, 2026
See bazelbuild/bazel#29931 -- this is going away
in upstream Bazel as well and has been a no-op since 2021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-internal-cleanup The PR cannot be merged, because that would be incompatible internally at Google. awaiting-review PR is awaiting review from an assigned reviewer community-reviewed Reviewed by a trusted community contributor team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants