Bump rules_python to 2.2.0 - #30134
Conversation
b9e99cc to
59228b1
Compare
Update MODULE.bazel and MODULE.bazel.lock. Update the rules_python test mocks. Use host Python for nested tests that retain rules_python 1.7.0 and for sha256_test on Windows. Package test_credential_helper as an explicit Windows zipapp.
59228b1 to
e8bff75
Compare
|
Is the failing CI okay? |
I think so? I have seen various windows shard failures on many PRs recently. This one is: Hopefully we can swap to @llvm soon to get a hermetic cc toolchain and put an end to these issues :) |
|
Yes, this will be fixed by a rules_cc update @pzembrod |
|
Indeed. Looks like nothing's passing recently. #30114 |
| @@ -158,6 +159,16 @@ def GetModuleVersionFromDefaultLockFile(self, module): | |||
|
|
|||
| def AddBazelDep(self, module, path=''): | |||
| version = self.GetModuleVersionFromDefaultLockFile(module) | |||
There was a problem hiding this comment.
Missing a function docstring here. Could you please add? @dzbarsky
|
@dzbarsky Thank you! We're currently working on merging this. |
|
Is there any reason not to merge now (aside rfom the branch conflict - can we resolve that?) |
@gregestren I was working on merging this. I'll assign you as a reviewer as well along with @aranguyen. Also, the merge conflict you see is from the MODULE.bazel.lock, which we can resolve on our own internally by updating the lockfile. So no need for the PR author to fix this since all other tests passed. |
Summary
Bump
rules_pythonfrom 1.7.0 to 2.2.0 and regenerateMODULE.bazel.lockwith Bazel 9.1.1.This gives us bazel-contrib/rules_python@1d99f70 which closes a hermiticity gap experienced by Bazel's own build.
Build API Changes
No.
Validation
Release Notes
RELNOTES: None