Skip to content

Bump rules_python to 2.2.0 - #30134

Open
dzbarsky wants to merge 2 commits into
bazelbuild:masterfrom
dzbarsky:codex/bump-rules-python-2.2.0
Open

Bump rules_python to 2.2.0#30134
dzbarsky wants to merge 2 commits into
bazelbuild:masterfrom
dzbarsky:codex/bump-rules-python-2.2.0

Conversation

@dzbarsky

@dzbarsky dzbarsky commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Bump rules_python from 1.7.0 to 2.2.0 and regenerate MODULE.bazel.lock with Bazel 9.1.1.

This gives us bazel-contrib/rules_python@1d99f70 which closes a hermiticity gap experienced by Bazel's own build.

Build API Changes

No.

Validation

Release Notes

RELNOTES: None

@dzbarsky
dzbarsky force-pushed the codex/bump-rules-python-2.2.0 branch 6 times, most recently from b9e99cc to 59228b1 Compare July 4, 2026 22:23
Update MODULE.bazel and MODULE.bazel.lock. Update the rules_python test mocks. Use host Python for nested tests that retain rules_python 1.7.0 and for sha256_test on Windows. Package test_credential_helper as an explicit Windows zipapp.
@dzbarsky
dzbarsky force-pushed the codex/bump-rules-python-2.2.0 branch from 59228b1 to e8bff75 Compare July 4, 2026 22:36
@dzbarsky
dzbarsky marked this pull request as ready for review July 4, 2026 22:53
@dzbarsky
dzbarsky requested a review from a team as a code owner July 4, 2026 22:53
@dzbarsky
dzbarsky requested review from aranguyen and removed request for a team July 4, 2026 22:53
@github-actions github-actions Bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Jul 4, 2026
@gregestren

Copy link
Copy Markdown
Contributor

Is the failing CI okay?

@dzbarsky

dzbarsky commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Is the failing CI okay?

I think so? I have seen various windows shard failures on many PRs recently. This one is:

ERROR: C:/b/6s3poxhi/execroot/_main/_tmp/4d39d5a325ce8c71aa2ebb418c2fd310/_bazel_b/hu7r7lhl/external/bazel_tools/src/main/cpp/util/BUILD:96:11: Compiling src/main/cpp/util/port.cc failed: absolute path inclusion(s) found in rule '@@bazel_tools//src/main/cpp/util:port':
the source file 'src/main/cpp/util/port.cc' includes the following non-builtin files with absolute paths (if these are builtin files, make sure these paths are in your toolchain):
'C:/Program Files/LLVM/lib/clang/22/include/stddef.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_header_macro.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_ptrdiff_t.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_size_t.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_wchar_t.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_null.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_nullptr_t.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_max_align_t.h'
'C:/Program Files/LLVM/lib/clang/22/include/__stddef_offsetof.h'
'C:/Program Files/LLVM/lib/clang/22/include/yvals_core.h'
'C:/Program Files/LLVM/lib/clang/22/include/vadefs.h'
'C:/Program Files/LLVM/lib/clang/22/include/yvals_core.h'
'C:/Program Files/LLVM/lib/clang/22/include/stdint.h'
'C:/Program Files/LLVM/lib/clang/22/include/inttypes.h'
Target @@bazel_tools//src/tools/launcher:launcher failed to build

Hopefully we can swap to @llvm soon to get a hermetic cc toolchain and put an end to these issues :)

@fmeum

fmeum commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Yes, this will be fixed by a rules_cc update @pzembrod

@github-actions github-actions Bot added the community-reviewed Reviewed by a trusted community contributor label Jul 6, 2026
@gregestren

Copy link
Copy Markdown
Contributor

Indeed. Looks like nothing's passing recently. #30114

@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 6, 2026
@@ -158,6 +159,16 @@ def GetModuleVersionFromDefaultLockFile(self, module):

def AddBazelDep(self, module, path=''):
version = self.GetModuleVersionFromDefaultLockFile(module)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a function docstring here. Could you please add? @dzbarsky

@iancha1992

Copy link
Copy Markdown
Member

@dzbarsky Thank you! We're currently working on merging this.

@gregestren

gregestren commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Is there any reason not to merge now (aside rfom the branch conflict - can we resolve that?)

@iancha1992

iancha1992 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Is there any reason not to merge now (aside rom the branch conflict - can we resolve that?)

Is there any reason not to merge now (aside rom the branch conflict - can we resolve that?)

@gregestren I was working on merging this. I'll assign you as a reviewer as well along with @aranguyen. Also, the merge conflict you see is from the MODULE.bazel.lock, which we can resolve on our own internally by updating the lockfile. So no need for the PR author to fix this since all other tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally community-reviewed Reviewed by a trusted community contributor team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants