Fix BAZEL_DOC_TRIGGER_TOKEN scope comment to name bazel-docs - #30360
Open
zozo123 wants to merge 3 commits into
Open
Fix BAZEL_DOC_TRIGGER_TOKEN scope comment to name bazel-docs#30360zozo123 wants to merge 3 commits into
zozo123 wants to merge 3 commits into
Conversation
github-actions
Bot
added
team-OSS
The comment documenting BAZEL_DOC_TRIGGER_TOKEN said the fine-grained PAT is scoped to the bazel-contrib/bcr-ui repository, but the workflow sends its repository_dispatch to bazel-contrib/bazel-docs. bcr-ui is an unrelated repository, and a PAT scoped to it cannot perform the dispatch. The comment is a copy-paste leftover. Since it is what maintainers follow during the annual token rotation it describes, it would lead a rotated token to be scoped to the wrong repository and silently break the docs-update trigger. Correct it to name bazel-contrib/bazel-docs.
zozo123
force-pushed
the
fix/docs-trigger-token-scope-comment
branch
from
July 19, 2026 15:33
75fe02a to
befc7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The comment documenting
BAZEL_DOC_TRIGGER_TOKENintrigger-docs-update.ymlstates that the fine-grained PAT is "Scoped to thebazel-contrib/bcr-uirepository." The workflow, however, sends itsrepository_dispatchtobazel-contrib/bazel-docs.bcr-uiis an unrelated repository, and a PAT scoped to it cannot dispatch tobazel-docs.The comment is a copy-paste leftover. Because the comment is what maintainers follow during the annual token rotation it describes, it would lead a rotated token to be scoped to the wrong repository, silently breaking the docs-update trigger.
Fix
Correct the comment to name
bazel-contrib/bazel-docs, matching the repository the workflow actually dispatches to.