Validate resource requests before queueing - #30395
Open
tamird wants to merge 1 commit into
Open
Conversation
A permanently oversized resource request can wait behind worker quota or resources already in use. A later wake-up then throws on the releasing or window thread, while the waiting latch cannot deliver that error. Validate scaled requests against total capacity during initial acquisition so the requesting thread receives the existing failure code and impossible requests never enter the queue. Keep subsequent availability and wake-up checks boolean-only, removing the obsolete UserExecException plumbing from release, window, ResourceHandle, and the worker reaper.
github-actions
Bot
added
team-Performance
Contributor
Author
|
Extracted from #30310. Strict CPU-load scheduling exposed that a |
bigelephant29
approved these changes
Jul 27, 2026
Contributor
Author
|
@bigelephant29 thanks for the reviews. all the PRs you reviewed are still labeled |
bigelephant29
added
awaiting-PR-merge
Contributor
I think I only missed the labels for this one. The other ones are correctly labeled. As for the largest PR, I'll need to find time looping back to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A permanently oversized resource request can wait behind worker quota
or resources already in use. A later wake-up can then raise
NOT_ENOUGH_LOCAL_RESOURCE on the releasing or window thread, while the
waiting latch cannot deliver that error to the requesting action.
Validate scaled requests against total capacity during synchronized
initial acquisition, before any transient gate can queue them. Keep
subsequent availability and wake-up checks boolean-only, removing the
obsolete UserExecException plumbing from release, window,
ResourceHandle, and the worker reaper.