Clarify ResourceManager's allow-one guarantee - #30400
Closed
tamird wants to merge 1 commit into
Closed
Conversation
The class documentation promises global progress, but the allow-one policy only permits an unused resource type to exceed its capacity. Worker quota and concurrency limits can still block acquisition. Narrow the guarantee so callers do not rely on progress the manager cannot provide.
github-actions
Bot
added
team-Performance
Contributor
Author
|
Extracted from #30310. Review of the scheduling change exposed that the |
bigelephant29
approved these changes
Jul 27, 2026
bigelephant29
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class documentation promises global progress, but the allow-one
policy only permits an unused resource type to exceed its capacity.
Worker quota and concurrency limits can still block acquisition. Narrow
the guarantee so callers do not rely on progress the manager cannot
provide.