Skip to content

Fixed error message#737

Closed
alex wants to merge 2 commits intobazelbuild:masterfrom
alex:patch-1
Closed

Fixed error message#737
alex wants to merge 2 commits intobazelbuild:masterfrom
alex:patch-1

Conversation

@alex
Copy link
Copy Markdown
Contributor

@alex alex commented Dec 23, 2015

The product is now named bazel and that's the binary people have installed.

The product is now named bazel and that's the binary people have installed.
@janakdr
Copy link
Copy Markdown
Contributor

janakdr commented Dec 25, 2015

The product is still called blaze internally at Google. You can use the
GetProductName function just as it's used on the lines above and below your
change to fix the issue you're addressing in a portable way.
On Dec 23, 2015 11:13 AM, "Alex Gaynor" notifications@github.com wrote:

The product is now named bazel and that's the binary people have installed.

You can view, comment on, or merge this pull request online at:

#737
Commit Summary

  • Fixed error message

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#737.

@alex
Copy link
Copy Markdown
Contributor Author

alex commented Dec 25, 2015

@janakdr done. thanks!

@janakdr
Copy link
Copy Markdown
Contributor

janakdr commented Dec 25, 2015

Thanks for the proposed change, it looks good! Have you read the steps at
http://bazel.io/contributing.html? Unfortunately I think we're not yet set
up to accept git pull requests directly.
On Dec 25, 2015 10:51 AM, "Alex Gaynor" notifications@github.com wrote:

@janakdr https://github.com/janakdr done. thanks!


Reply to this email directly or view it on GitHub
#737 (comment).

@kchodorow
Copy link
Copy Markdown
Contributor

We can import changes from a GitHub pull request for simpler changes (which this qualifies as). I'll import it now.

kchodorow pushed a commit that referenced this pull request Dec 30, 2015
The product is now named bazel and that's the binary people have installed.

--
Reviewed-on: #737
MOS_MIGRATED_REVID=111071899
@damienmg
Copy link
Copy Markdown
Contributor

This was merged, closing

@damienmg damienmg closed this Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants