Windows: Ignore workspace name differences while doing header checking#9188
Closed
meteorcloudy wants to merge 3 commits into
Closed
Windows: Ignore workspace name differences while doing header checking#9188meteorcloudy wants to merge 3 commits into
meteorcloudy wants to merge 3 commits into
Conversation
meteorcloudy
requested review from
hlopko,
oquenchil and
scentini
as code owners
August 16, 2019 10:11
meteorcloudy
requested review from
laszlocsomor
and removed request for
hlopko and
scentini
August 16, 2019 10:12
laszlocsomor
suggested changes
Aug 16, 2019
laszlocsomor
left a comment
laszlocsomor
left a comment
Contributor
There was a problem hiding this comment.
Can you also add an integration test?
Member
Author
|
Integration test added, PTAL~ |
meteorcloudy
force-pushed
the
fix_header_check
branch
from
August 19, 2019 09:57
97dfa31 to
32495ad
Compare
laszlocsomor
approved these changes
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9172