Add hooks to capture bootstrap durations in windows and linux#2530
Add hooks to capture bootstrap durations in windows and linux#2530
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Buildkite agent hook scripts on Windows and Linux workers to capture checkout/prep timing signals for CI metrics (Wall Time Component Breakdown).
Changes:
- Add Windows Buildkite hook scripts (
pre-checkout,post-checkout,pre-command) to record timestamps and durations into Buildkite job env vars. - Add equivalent Linux hook scripts under
/etc/buildkite-agent/hooks/to export the same timing env vars. - Emit timing values to hook stdout for easier log inspection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| buildkite/startup-windows-pdssd.ps1 | Writes new PowerShell hook files to export job timing env vars on Windows agents. |
| buildkite/startup-docker-pdssd.sh | Writes new Bash hook files to export job timing env vars on Linux (docker) agents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@SalmaSamy Can you check the copilot comments? Maybe it's related to the mysterious missing metrics you saw? |
|
@copilot apply changes based on the comments in this thread |
Not related but they are still good. |
All four validation changes from the review thread were already applied in commit
|
|
Yes, please avoid apply those changes directly, you can squash all commits and fix the commit description. |
Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Triggering CI pipeline
The annotation contains links to resources that are helpful when debugging .mdx parsing errors. Demo: https://buildkite.com/bazel-testing/fwe-test/builds/60
As of bazel-contrib/bazel-docs#311 we're using the new `$ref` feature, which means our navigation now consists of multiple json files.
This image will be used in the bazel-testing org, allowing us to test changes more easily.
The version number will look like `8.7.0-pre-<commit>`.
The "Resolving test targets via bazel query" phase doesn't filter them and passes an explicit list to "test" which can't filter it due to it being explicitly requested
- Update the same comment instead of posting one every time - Add a summary of the changes at the top - Fix the too long comment problem on github: [exmaple](https://github.com/bazelbuild/continuous-integration/actions/runs/23867137759/job/69589214776?pr=2470)
SalmaSamy
force-pushed
the
update-startup-scripts
branch
from
fef9cc5 to
0f64885
Compare
These vars will be collected in CI-Metrics to help visualize Wall Time Component Breakdown