Adopt symbolic macros for public-facing API#2933
Merged
aaronsky merged 1 commit intoMay 14, 2026
Merged
Conversation
aaronsky
force-pushed
the
aaronsky/symbolic-macros-for-public-api
branch
6 times, most recently
from
7cf86dc to
abe93e2
Compare
This PR migrates legacy macros in our public API to symbolic macros, now that we're on Bazel 8. This will allow downstream consumers to wrap these macros in their own symbolic macros. Reviewers and tests should assert that this PR: - Does not introduce breaking changes, except where possible to support symbolic macros - Does not regress functionality through new attr type annotations or performance characteristics - Makes sense to do at all
aaronsky
force-pushed
the
aaronsky/symbolic-macros-for-public-api
branch
from
abe93e2 to
3d4160b
Compare
aaronsky
requested review from
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
keith
approved these changes
May 14, 2026
congt
reviewed
May 31, 2026
aaronsky
added a commit
that referenced
this pull request
May 31, 2026
Addresses feedback in #2933 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates legacy macros in our public API to symbolic macros, now that we're on Bazel 8. This will allow downstream consumers to wrap these macros in their own symbolic macros. It does not make any changes to the core_ml and intent library macros in
apple/resources.bzl.Reviewers and tests should assert that this PR: