Create repositories.bzl#10
Merged
Merged
Conversation
This will help if we need to add dependencies or declare toolchains in the future because users already have everything in their WORKSPACE
iirina
reviewed
Jul 30, 2019
| # Empty WORKSPACE file. | ||
| workspace(name = "rules_java") | ||
|
|
||
| load("//java:repositories.bzl", "rules_java_dependencies", "rules_java_toolchains") |
Contributor
There was a problem hiding this comment.
Can we use @rules_java//java:repositories.bzl here so this part can be easily copy-pasted?
iirina
approved these changes
Jul 30, 2019
bazel-io
pushed a commit
that referenced
this pull request
Jul 31, 2019
PiperOrigin-RevId: 260874946 Change-Id: Id579b85d543ed57110e5aa88df4fc3e3d50bc0d5
Contributor
|
@Yannic I had to add module docstrings because buildifier was complaining about it in our internal presubmit, I hope it's ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help if we need to add dependencies or declare toolchains in
the future because users already have everything in their WORKSPACE