Check local version detection result#171
Check local version detection result#171bertschneider wants to merge 1 commit intobazelbuild:masterfrom
Conversation
|
As the Java installation was detected via |
|
cc @fmeum |
bertschneider
force-pushed
the
fix_local_version_detection
branch
from
aca5d29 to
87bdb9e
Compare
|
Looks like buildifier complains, but the other CI failure seems unrelated. |
bertschneider
force-pushed
the
fix_local_version_detection
branch
from
87bdb9e to
add18e2
Compare
|
Do you have an idea what's causing the failed checks? |
Looks like this is coming from the new test setup: rules_java/.bazel_checkout/setup.sh Lines 5 to 9 in 4f46f3a cc @hvadehra |
|
Should be fixed after 88bb3ad. Could you please rebase on master? |
In case the local version detection fails, e.g. due to a corrupt installation, skip further processing, as it results in a type error.
bertschneider
force-pushed
the
fix_local_version_detection
branch
from
add18e2 to
6943c45
Compare
Done. It fixed the failed checks, thx! |
| if version == None: | ||
| # Java version could not be detected | ||
| message = "Cannot detect Java version of {java_binary} in {java_home}; make sure it points to a valid Java executable" | ||
| repository_ctx.file( |
There was a problem hiding this comment.
It might be worth extractor a helper function to share this with the copy above, I think the only different here is the message?
4 participants
In case the local Java version detection fails, e.g. due to a corrupt installation, skip further processing, as it results in a type error.
Closes #170