Do not enable use_all_repos for toolchains extension#191
Closed
fmeum wants to merge 1 commit into
Closed
Conversation
The toolchain extension isn't internal to rules_java as users have to `use_extension` it to get a reference to `local_jdk`. They should not see a warning about not importing all the other repos, which comes with `modules.as_extension` due to its use of `use_all_repos`. Instead, just declare the extension as reproducible.
hvadehra
approved these changes
May 17, 2024
Contributor
Author
|
@hvadehra Sorry for messing this up, I noticed it when I saw the warning pop up on Bazel itself. As it would make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolchain extension isn't internal to rules_java as users have to
use_extensionit to get a reference tolocal_jdk. They should not see a warning about not importing all the other repos, which comes withmodules.as_extensiondue to its use ofuse_all_repos. Instead, just declare the extension as reproducible.