refactor MODULE.bazel file #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `register_toolchains(...)` instead of `module(..., toolchains_to_register = [...])`. The former allows us to put the `module` directive at the very top of the file, improving readability.
Wyverald
requested review from
a team,
c-mita,
comius,
cushon,
katre,
lberki and
oquenchil
as code owners
katre
previously approved these changes
Aug 17, 2022
comius
previously approved these changes
Aug 18, 2022
Collaborator
|
@Wyverald Buildifier is complaining |
Member
Author
|
PTAL |
comius
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
register_toolchains(...)instead ofmodule(..., toolchains_to_register = [...]). The former allows us to put themoduledirective at the very top of the file, improving readability.