rustc: fix a conditional #1300
Merged
rustc: fix a conditional #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`("bar" or "baz")` always evaluates to "bar", so this conditional
ignores `"dylib"`. This seems unintended.
UebelAndre
approved these changes
Apr 26, 2022
Collaborator
|
IIUC we currently don't have a use case for |
1 similar comment
Collaborator
|
IIUC we currently don't have a use case for |
scentini
approved these changes
Apr 27, 2022
Contributor
Author
|
(Thank you all! :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
("bar" or "baz")always evaluates to "bar", so this conditional ignores"dylib". This seems unintended.I don't have a particular test-case in mind for this; just noticed the oddity as I was browsing through the code.
cc @krasimirgg, who seems to have tweaked things around here recentlyish?