Skip to content

rustc: fix a conditional #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2022
Merged

rustc: fix a conditional #1300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8741efc
rustc: fix a conditional
gburgessiv Apr 26, 2022
91b552c
Merge branch 'main' into rustc-fix-a-conditional
scentini Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def _are_linkstamps_supported(feature_configuration, has_grep_includes):
has_grep_includes)

def _should_use_pic(cc_toolchain, feature_configuration, crate_type):
if crate_type in ("cdylib" or "dylib"):
if crate_type in ("cdylib", "dylib"):
return cc_toolchain.needs_pic_for_dynamic_libraries(feature_configuration = feature_configuration)
return False

Expand Down