Avoid emitting -LNone in developer_dirs_linkopts on Linux - #1670
Merged
Conversation
When `developer_dirs` is empty, `swift_developer_lib_dir(...)` returns `None`. `developer_dirs_linkopts(...)` was still formatting that value as a library search path, which produced `-LNone` in the final link command. Fix this by only adding the `-L...` flag when a real Swift developer library directory exists, and add unit tests covering empty, non-platform, and platform developer dir cases.
bc-lee
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
March 29, 2026 09:38
keith
approved these changes
Mar 29, 2026
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
developer_dirsis empty,swift_developer_lib_dir(...)returnsNone.developer_dirs_linkopts(...)was still formatting that value as a library search path, which produced-LNonein the final link command.Fix this by only adding the
-L...flag when a real Swift developer library directory exists, and add unit tests covering empty, non-platform, and platform developer dir cases.Fixes #1669