Replace ZWA-2 string-based discovery with VID/PID lookup#21
Merged
Conversation
…js manifest Co-authored-by: bbangert <100193+bbangert@users.noreply.github.com>
…icate lookup Co-authored-by: bbangert <100193+bbangert@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add discovery by VID/PID for ESPHome
Replace ZWA string-based discovery with VID/PID lookup
Feb 24, 2026
bbangert
reviewed
Feb 24, 2026
bbangert
requested changes
Feb 24, 2026
Co-authored-by: bbangert <100193+bbangert@users.noreply.github.com>
bbangert
requested changes
Feb 24, 2026
Copilot
AI
changed the title
Replace ZWA string-based discovery with VID/PID lookup
Replace ZWA-2 string-based discovery with VID/PID lookup
Feb 24, 2026
bbangert
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZWA-2 auto-detection was matching on manufacturer/description strings (
"Nabu Casa"/"ZWA-2"). This switches to VID/PID matching using the ZWA-2's USB identifiers from Home Assistant'szwave_js/manifest.json, which is more reliable.Changes
lib/universal_proxy/uart/server.ex@zwa2_manufacturer/@zwa2_productstring constants with@zwa2_vid(0x303A) /@zwa2_pid(0x4001) integer constantszwa2_device?/1now matches by VID/PID instead of substring-matching manufacturer/description stringstest/universal_proxy/uart/server_test.exs— new tests for VID/PID matching (positive match, rejection of unknown/missing VID/PID)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.