Deprecate helm-projectile-ack - #215
Merged
Merged
Conversation
ack has been superseded by ripgrep and the silver searcher, and Projectile itself has dropped `projectile-ack' (so helm-projectile-ack shadows a command that no longer exists upstream, and it was reachable only via M-x anyway). Mark it obsolete via `make-obsolete', pointing users at `helm-projectile-rg' / `helm-projectile-ag'. It keeps working for now; the ack machinery in `helm-projectile-grep-or-ack' and `helm-projectile--wildcard-to-ack-match' will be removed together with the command in a future release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the dead/obsolete audit. ack is legacy: it's been superseded by ripgrep and the silver searcher (both already supported via
helm-projectile-rg/helm-projectile-ag), and Projectile itself droppedprojectile-ack- sohelm-projectile-acknow shadows a command that no longer exists upstream, and it was only reachable viaM-x(the toggle remaps grep/ag/ripgrep, not ack).Rather than remove it outright, this marks it obsolete via
make-obsolete(pointing at rg/ag), with a docstring note and README/CHANGELOG entries. It keeps working for the 1.7.0 cycle; theuse-ack-pmachinery inhelm-projectile-grep-or-ackandhelm-projectile--wildcard-to-ack-matchwill be removed together with the command in a future release.A test asserts the command carries obsolete info.
M-x checkdocwarnings