Skip to content

Add :package-version to every defcustom - #220

Merged
bbatsov merged 1 commit into
masterfrom
defcustom-package-version
Jul 8, 2026
Merged

Add :package-version to every defcustom#220
bbatsov merged 1 commit into
masterfrom
defcustom-package-version

Conversation

@bbatsov

@bbatsov bbatsov commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Last of the five improvements (the Codecov half of #5 already landed once you added the token). None of the 13 defcustoms carried a :package-version, so Customize couldn't say which release introduced each option and M-x customize-changed couldn't surface them on upgrade.

Adds :package-version '(helm-projectile . "X") to all 13, with the version for each derived from git archaeology (the first release tag whose history contains the option's introduction). Recent ones map to 1.6.0; the oldest to 0.14.0 / 1.0.0.

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog
  • You've updated the readme (no user-facing change)

None of the 13 options carried a `:package-version', so Customize and
`M-x customize-changed' couldn't tell users which release introduced (or
last changed) each one.  Add it to all of them, with versions derived
from each option's introducing release.
@bbatsov
bbatsov merged commit c2b0481 into master Jul 8, 2026
10 checks passed
@bbatsov
bbatsov deleted the defcustom-package-version branch July 8, 2026 11:45
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.17%. Comparing base (865e58d) to head (08016bc).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           1        1           
  Lines         560      560           
=======================================
  Hits          309      309           
  Misses        251      251           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants