Build the search ignores from Projectile's patterns - #222
Merged
Conversation
Projectile 3.3 collapsed its ignore machinery into a single list of gitignore-style patterns and dropped the path lists we were reading - projectile-ignored-files-rel, projectile-ignored-directories-rel and projectile-patterns-to-ignore - so every search command errored out. Read projectile-filtering-patterns instead and split it on the trailing slash that marks a directory-only rule, since helm-grep wants ignored files and directories as two lists. The anchoring markers come off: the search tools take plain globs and have no notion of a rule anchored to the project root. The ack path no longer appends projectile-patterns-to-ignore separately - the pattern list already covers it. One of the new specs goes through Projectile unstubbed. The suite was spying on the very functions that had been deleted, so it stayed green through this breakage.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 55.17% 55.65% +0.47%
==========================================
Files 1 1
Lines 560 566 +6
==========================================
+ Hits 309 315 +6
Misses 251 251 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projectile 3.3 turned its ignore configuration into a single list of gitignore-style patterns and dropped the path lists helm-projectile was reading, so every search command errored out. This reads
projectile-filtering-patternsinstead, splitting it on the trailing slash that marks a directory-only rule (helm-grep wants ignored files and directories as two separate lists) and stripping the anchoring markers, since the search tools take plain globs.Bumps the Projectile requirement to 3.3.0 accordingly - the new API is where the ignore rules live now.
One of the new specs runs unstubbed against Projectile. The suite had been spying on the very functions that got deleted, which is why it stayed green through this.
Fixes #221