Made createImageBitmap usage Firefox compliant #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakca
approved these changes
Nov 25, 2022
Member
yakca
left a comment
yakca
left a comment
There was a problem hiding this comment.
Looks like this no longer an issue these days but I don't see any harm in makings these explicit and gives some legacy compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try and render image nodes in Firefox you will get the following error:
This is because Firefox does not support passing options as the second argument in the function, whereas the 6 argument variant works as intended.
Before: https://codesandbox.io/s/videocontext-imagenode-xrrg3?file=/src/index.js
After: https://codesandbox.io/s/videocontext-imagenode-pk6sy