Skip to content

Remove cache circuit breaker#43

Merged
chr15stevens merged 3 commits intomainfrom
IPLAYER-45836-cache-circuit-breaker
Dec 6, 2024
Merged

Remove cache circuit breaker#43
chr15stevens merged 3 commits intomainfrom
IPLAYER-45836-cache-circuit-breaker

Conversation

@chr15stevens
Copy link
Contributor

Description

Removed circuit breaker from http-transport-cache.

Motivation and Context

The cache circuit breaker was doing very little to protect caches in the case of the recommended catbox-redis and redisio cache libraries. We decided to remove this and consumers of this library should implement their own circuit breaker if necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] -I have added tests to cover my changes.- No new tests required, only removals.
  • All new and existing tests passed.

@chr15stevens chr15stevens requested a review from a team as a code owner December 6, 2024 12:03
@chr15stevens chr15stevens changed the title Iplayer 45836 cache circuit breaker Remove cache circuit breaker Dec 6, 2024
@chr15stevens chr15stevens merged commit fd6a1ca into main Dec 6, 2024
@chr15stevens chr15stevens deleted the IPLAYER-45836-cache-circuit-breaker branch December 6, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants