sanitize transport options#2
Merged
Merged
Conversation
*Problem* Some transport options are invalid when passed to the tcp transport, but machine_gun pools are specified not for a specific host-port pair but for a so called "pool group", this means that options set for the ssl transport are being passed to the tcp transport and causing failure. *Solution* Drop invalid options depending on the given transport. Currently only `verify`, as that is the option that is being specified.
samfrench
approved these changes
Mar 25, 2022
Author
|
Demo of the problem First install Passing invalid arguments to the tcp transport raises an error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some transport options are invalid when passed to the tcp transport,
but machine_gun pools are specified not for a specific host-port pair
but for a so called "pool group", this means that options set for the
ssl transport are being passed to the tcp transport and causing
failure.
Solution
Drop invalid options depending on the given transport.
Currently only
verify, as that is the option that is being specified.