Merged
Conversation
andysteadbbc
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧐 What?
This PR (naughtily) makes two changes (if you'd much rather have two separate PRs do let me know!):
Code block formatting
Format
<code>blocks more consistently. Currently the styling is inconsistent if the<code>block is in a paragraph or in some kind of list. Here's an example (seen on this page):Root links in
<link>tagsGitHub supports links relative to the root of the repository (e.g.
/README.mdmaps to the top level readme file regardless of the location of the file it's in). It's sometimes handy to be able to add custom styles formorty-docsfiles. This is currently possible by adding a<link>tag:This gets quite painful quite quickly if there are lots of MarkDown files in lots of sub-folders (e.g. these files since you have to continually adjust the relative path in the
href.It would be nicer if we supported links relative to the root of the repository in
<link>tags as well as<a>tags:🛠 How
codeCSS selector to use:not(pre)instead ofpto target allcodeblocks not in apreaddBasePathToRootLinkstransformer to handlelinktaghrefattributes that are relative to the root of the repository