Bugfix: Don't add waveform layer to the overview stage twice and ensure the UI layer is on top#127
Merged
thom4parisot merged 1 commit intobbc:masterfrom Sep 17, 2015
Merged
Conversation
Contributor
Author
|
@oncletom Any chance of getting this reviewed? :) |
thom4parisot
pushed a commit
that referenced
this pull request
Sep 17, 2015
Bugfix: Don't add waveform layer to the overview stage twice and ensure the UI layer is on top
Contributor
|
@ziggythehamster thanks for the reminder and fix, was away for a month and lost track of untriaged issues :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createWaveformadds the waveform layer to the stage already, but then we re-add it to the stage. I'm unsure exactly what effect this has (@johvet probably does), but it definitely seems incorrect. The UI layer also needed to be moved on top of the other layers, because the waveform was covering up the playhead and other important bits.