Improving performances with hundreds of segments#5
Merged
thom4parisot merged 5 commits intomasterfrom Jan 28, 2014
Merged
Conversation
|
👍 |
- basically removing an always encountered `else` path - applying proper Array function as it's supposed to be available in all browsers using Canvas
- adding sinon for stubs - minor tweaks, like `==` -> `===` or parenting an anonymous function
Also removed an uneeded call for drawing, having a *2 impact.
thom4parisot
pushed a commit
that referenced
this pull request
Jan 28, 2014
[READY] Segments performance boost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @JamesHarrison, if we try to add 300 segments, it has a major performance hit on the rendering.
Investigate a way to batch the segments drawing/rendering.