Skip to content

WORLDSERVICE-185: Replace uuid with crypto.randomUUID#12361

Merged
karinathomasbbc merged 28 commits intolatestfrom
replace-uuid-with-crypto
Mar 13, 2025
Merged

WORLDSERVICE-185: Replace uuid with crypto.randomUUID#12361
karinathomasbbc merged 28 commits intolatestfrom
replace-uuid-with-crypto

Conversation

@karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Feb 4, 2025

Resolves JIRA https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-185

Overall changes

Replaces uuid with crypto.randomUUID as uuid is out of date, and we are unable to upgrade due to incompatibility with Opera Mini

Code changes

  • Create a new function - getUUID to generate a unique ID
  • Update all references to uuid with getUUID
  • Update unit tests

Testing

  • Preview environment
    • Opera Mini
      • Pages should continue to render OK
      • Page View beacon sent to ATI
    • Incognito mode
      • Optimizely Experiment - ensure ckns_mvt cookie value is a unique ID
      • ATI - ensure idclient in the network request is a unique ID / atuserid cookie is a unique ID
      • Uploader form - ensure said in the POST request is a unique ID

Tested with Opera Mini Emulator, page renders as expected & ATI Page View event sent

Screenshot 2025-03-06 at 18 56 09

@karinathomasbbc karinathomasbbc self-assigned this Feb 4, 2025
@karinathomasbbc karinathomasbbc changed the title Replace references of uuid with crypto.randomUUID WORLDSERVICE-185: Replace references of uuid with crypto.randomUUID Mar 6, 2025
@karinathomasbbc karinathomasbbc changed the title WORLDSERVICE-185: Replace references of uuid with crypto.randomUUID WORLDSERVICE-185: Replace uuid with crypto.randomUUID Mar 6, 2025
@karinathomasbbc karinathomasbbc marked this pull request as ready for review March 12, 2025 09:17
@karinathomasbbc karinathomasbbc merged commit 51131b8 into latest Mar 13, 2025
11 checks passed
@karinathomasbbc karinathomasbbc deleted the replace-uuid-with-crypto branch March 13, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants