Skip to content

WORLDSERVICE-284 Automated testing to determine the weight of lite pages#12561

Merged
emilysaffron merged 25 commits intolatestfrom
SPIKE-WORLDSERVICE-284-automate-litepage-weight-test
Mar 27, 2025
Merged

WORLDSERVICE-284 Automated testing to determine the weight of lite pages#12561
emilysaffron merged 25 commits intolatestfrom
SPIKE-WORLDSERVICE-284-automate-litepage-weight-test

Conversation

@emilysaffron
Copy link
Contributor

@emilysaffron emilysaffron commented Mar 24, 2025 •
edited
Loading

Resolves JIRA: WORLDSERVICE-284

Summary

Adds a script to check page weight of lite pages on live and local, running as part of the local server github action.

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@emilysaffron emilysaffron self-assigned this Mar 25, 2025
karinathomasbbc
karinathomasbbc reviewed Mar 25, 2025
View reviewed changes
karinathomasbbc
karinathomasbbc reviewed Mar 25, 2025
View reviewed changes
@emilysaffron emilysaffron changed the title create lite page size checker script WORLDSERVICE-284 Automated testing to determine the weight of lite pages Mar 25, 2025
karinathomasbbc
karinathomasbbc reviewed Mar 25, 2025
View reviewed changes
emilysaffron and others added 7 commits March 25, 2025 13:48
@emilysaffron @karinathomasbbc
Update scripts/litePageSizeValidator/index.js
7245ac8 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
@emilysaffron @karinathomasbbc
Update scripts/litePageSizeValidator/index.js
c5b4aff 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
@emilysaffron @karinathomasbbc
Update scripts/litePageSizeValidator/index.js
f75d44b 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
@emilysaffron
rename pagetypes
06c61f6
@emilysaffron
convert to bytes in seperate function
c8431ba
@emilysaffron
return full urls in result
9adddf3
@emilysaffron
rename function
e009b97
karinathomasbbc
karinathomasbbc reviewed Mar 25, 2025
View reviewed changes
emilysaffron and others added 3 commits March 25, 2025 14:38
@emilysaffron @karinathomasbbc
Update scripts/litePageSizeValidator/index.js
83d3a0a 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
@emilysaffron @karinathomasbbc
Update scripts/litePageSizeValidator/index.js
00087dc 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
@emilysaffron
sort table response
5220531
karinathomasbbc
karinathomasbbc reviewed Mar 25, 2025
View reviewed changes
emilysaffron and others added 2 commits March 25, 2025 14:56
@emilysaffron @karinathomasbbc
Update scripts/litePageSizeValidator/index.js
c0a33a1 
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
@emilysaffron
Merge branch 'latest' into SPIKE-WORLDSERVICE-284-automate-litepage-w…
afb3b65 
…eight-test
karinathomasbbc
karinathomasbbc reviewed Mar 25, 2025
View reviewed changes
@karinathomasbbc
Copy link
Contributor

karinathomasbbc commented Mar 25, 2025

The nextJS pages seem to be bigger on live than they are on local. I am thinking that those pages are not actually compressed...

Screenshot 2025-03-25 at 17 20 40

@karinathomasbbc
Copy link
Contributor

karinathomasbbc commented Mar 25, 2025

I've noticed quite a big discrepancy between On Demand TV Brand pages - looks like https://www.bbc.com/gujarati/bbc_gujarati_tv/tv_programmes/w13xttqr.lite?renderer_env=live 404s. I think we should add some error checking, and ensure the response we get back from the curl is a 200.

@amoore108
Copy link
Contributor

amoore108 commented Mar 26, 2025 •
edited
Loading

One to note is ws/languages isn't setup for .lite routing just yet. So the page its visiting and getting the content-length back for is likely a generic 404 page.

We may want to do something to highlight 404s and either not try and calculate the size and/or display a warning that the route 404'd?

@emilysaffron
handle non-200 status codes
47f5850
@emilysaffron
Merge branch 'SPIKE-WORLDSERVICE-284-automate-litepage-weight-test' o…
7072732 
…f github.com:bbc/simorgh into SPIKE-WORLDSERVICE-284-automate-litepage-weight-test
Isabella-Mitchell
Isabella-Mitchell reviewed Mar 27, 2025
View reviewed changes
Isabella-Mitchell
Isabella-Mitchell reviewed Mar 27, 2025
View reviewed changes
scripts/litePageSizeValidator/index.js

console.table(testResults.sort((a, b) => b.localSizeKb - a.localSizeKb));

const failures = testResults.filter(({ result }) => result === '❌');
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy since this works and it is a developer script. Though I'm not sure I've seen a strict equality check against an emoji before! ===😄

Isabella-Mitchell
Isabella-Mitchell approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a test to fix

@emilysaffron emilysaffron merged commit 99057d5 into latest Mar 27, 2025
11 checks passed
@emilysaffron emilysaffron deleted the SPIKE-WORLDSERVICE-284-automate-litepage-weight-test branch March 27, 2025 11:25
@karinathomasbbc karinathomasbbc mentioned this pull request Apr 2, 2025
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HarveyPeachey HarveyPeachey HarveyPeachey approved these changes

@Isabella-Mitchell Isabella-Mitchell Isabella-Mitchell approved these changes

+1 more reviewer

@karinathomasbbc karinathomasbbc karinathomasbbc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@emilysaffron emilysaffron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilysaffron @karinathomasbbc @amoore108 @HarveyPeachey @Isabella-Mitchell