WS-2411: Fix Brand header logo position for long brands#13842
Merged
WS-2411: Fix Brand header logo position for long brands#13842
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression where long brand logos/names in the header were no longer centered on smaller screens by adjusting the psammead-brand layout and constraining SVG sizing.
Changes:
- Updates
Banner/SvgWrapperlayout to use flex stretching so the brand content stays vertically aligned when wrapping on small viewports. - Adds
max-width: 100%to the brand SVG to prevent overflow on narrow screens. - Regenerates affected Jest snapshots across legacy containers and PageLayoutWrapper.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/app/legacy/psammead/psammead-brand/src/index.jsx |
Core styling adjustments to keep long brands centered and prevent SVG overflow. |
src/app/legacy/psammead/psammead-brand/src/__snapshots__/index.test.jsx.snap |
Snapshot updates reflecting new Banner/SvgWrapper/BrandSvg styles. |
src/app/legacy/containers/Header/__snapshots__/index.test.jsx.snap |
Snapshot updates due to brand style changes impacting header rendering. |
src/app/legacy/containers/Footer/__snapshots__/index.test.jsx.snap |
Snapshot updates due to brand style changes impacting footer rendering. |
src/app/legacy/containers/Brand/__snapshots__/index.test.jsx.snap |
Snapshot updates due to brand style changes in Brand container. |
src/app/components/PageLayoutWrapper/__snapshots__/index.test.tsx.snap |
Snapshot updates where the brand/header rendering is included in layout wrapper output. |
amoore108
approved these changes
Mar 27, 2026
jinidev
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2411
Summary
align-items: stretch;to the Banner component and setsmax-width: 100%;to ensure the SVG logo doesn’t overflow and remains vertically centered on smaller screens.Testing
Useful Links