FIX: Always display error page in Next.js app locally#13900
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the local developer experience in the ws-nextjs-app Next.js application by ensuring invalid local routes consistently render the standard 404 error page (instead of a blank screen), even when the “service” segment in the URL is not a recognised Simorgh service.
Changes:
- Validates the
serviceextracted from the URL against the canonical services list and falls back tonewswhen invalid, so the error page can render. - Replaces hard-coded
404values with the sharedNOT_FOUNDstatus constant.
elvinasv
approved these changes
Apr 10, 2026
shayneahchoon
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small fix to always display an error page if the route being viewed locally is incorrect.
Previously just a blank white page would be displayed for a route that didn't match.
This is just a local development aid, as upstream systems define "valid" routes for the application and return a static 404 page in instances that routes aren't matched.
Testing
http://localhost:7081/foobar
http://localhost:7081/foobar.amp
http://localhost:7081/igbo/foobar
http://localhost:7081/igbo/foobar.amp
Useful Links