WS-2486-Fix keyboard navigation order of new nav component#14035
Merged
alex-magana merged 32 commits intoJun 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes keyboard navigation order in the new canonical navigation component by closing the dropdown menu when keyboard focus moves outside of its container.
Changes:
- Adds an
onBlurhandler on the wrapper div around the top row and dropdown. - Uses
currentTarget.contains(relatedTarget)to detect focus leaving the menu subtree and closes the menu when it does.
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ew-nav-component
| shiftKey, | ||
| currentTarget, | ||
| }: KeyboardEvent) => { | ||
| if (key !== 'Tab' || shiftKey) return; |
Contributor
There was a problem hiding this comment.
Don't understand this one. Can you explain?
Contributor
Author
There was a problem hiding this comment.
Realised it wasn't needed, it's been removed.
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ent' of github.com:bbc/simorgh into WS-2486-fix-keyboard-navigation-order-of-new-nav-component
…ew-nav-component
pvaliani
approved these changes
Jun 2, 2026
…ent' of github.com:bbc/simorgh into WS-2486-fix-keyboard-navigation-order-of-new-nav-component
shayneahchoon
approved these changes
Jun 2, 2026
…ew-nav-component
…ew-nav-component
…ew-nav-component
…ew-nav-component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2486
Summary
Fixes keyboard navigation so what the focus does not go onto the 2nd tier but instead, the focus closes the menu and moves to the first item on the page as required.
Code changes
blurevent listener function for closing menu when tabbing after last element in drop down menu.testHelpersto include real links so the test accurately reflects how the dropdown menu works in practice.Testing
Useful Links