Fix Autoscroll detaches from Onair Line #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance was called fix, use timeout and measure scroll to position
… no longer called 10 times on a take
…as just a 5sec delay to adjust the virtualElement. Instead there's a state in viewPort telling if it's scrolling
…it shouldn't happen at all)
…(fix if more than 1 segment is invalid)
jstarpl
reviewed
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
Type of Contribution
This is a Bug fix and code improvement.
Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)
Current Behavior
The scrolling could jump a bit up and down, and this could cause the timeline to detach
New Behavior
A delay before detaching has been made, to ensure the UI has settled.
Timing optimizations has been made to avoid jumps and recursive realignments of the UI
Testing
Affected areas
Time Frame
Other Information
Status