fix: inactive playlist top bar readability#84
Merged
justandras merged 4 commits intorjmunro/t-timers-extrafrom Apr 9, 2026
Merged
fix: inactive playlist top bar readability#84justandras merged 4 commits intorjmunro/t-timers-extrafrom
justandras merged 4 commits intorjmunro/t-timers-extrafrom
Conversation
7 tasks
justandras
force-pushed
the
justandras/fix/top-bar-readability
branch
from
1475a8c to
e480d44
Compare
jesperstarkar
approved these changes
Apr 9, 2026
Collaborator
jesperstarkar
left a comment
jesperstarkar
left a comment
There was a problem hiding this comment.
Skimmed the code, looks good to me.
Tested locally, works perfectly.
rjmunro
pushed a commit
that referenced
this pull request
Apr 13, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 13, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 13, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 13, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 13, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 16, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 16, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 16, 2026
rjmunro
pushed a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a: Bug fix / UI improvement
Current Behavior
The dimmed top bar labels are hard to read when a playlist is not activated.
New Behavior
Use transparency for white color instead of hardcoding a grey color. I've also changed the clock color to white when deactivated.
Testing
Affected areas
This PR affects the top bar in the web ui.
Status