feat: adding strictreturn flag #604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new flag,
strictReturn, which enforces explicit return values from message handlers in order to prevent ambiguous acknowledgment behavior. When enabled, the consumer requires each handler (handleMessage or handleMessageBatch) to explicitly return one of the following:Message(or array of Messages) → acknowledge and delete the message(s)undefined→ leave the message(s) on the queue (nack)Returning null or omitting a return (i.e., void) is no longer permitted under
strictReturn.Motivation
Historically, handlers could return void or null, which SQS Consumer treated as “do nothing.”
This behavior often led to accidental message retention, especially when developers forgot to return a value.
The strictReturn flag:
This aligns with ongoing deprecation of void/null returns (see #598
Behavior