Merged
Conversation
- not tested, but should work
- not tested - linting passed
- tested and working
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deepCSA Nextflow pipeline to support alternate mutation inputs and additional downstream outputs, while also adjusting plotting and depth/panel utilities.
Changes:
- Add support for providing mutations via a MAF file (converted to per-sample VCFs) in the main workflow.
- Extend signature-matrix generation to additionally produce MSA-formatted mutation matrices.
- Adjust plotting/color handling and make depth/panel utilities robust to presence/absence of a
CONTEXTcolumn; enable caching more broadly.
Reviewed changes
Copilot reviewed 13 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/deepcsa.nf | Adds input_maf handling path (MAF→VCF) and wires it into downstream steps |
| subworkflows/local/enrichpanels/main.nf | Removes unused bedfile inputs from ENRICHPANELS interface |
| nextflow_schema.json | Adds input_maf parameter; removes create_sample_panels |
| nextflow.config | Adds params.input_maf default |
| modules/nf-core/tabix/bgziptabixquery/main.nf | Enables caching by removing explicit cache false |
| modules/nf-core/tabix/bgziptabix/main.nf | Enables caching by removing explicit cache false |
| modules/local/sig_matrix_concat/main.nf | Emits new *.msa.csv matrix outputs |
| modules/local/downsample/mutations/main.nf | Enables caching by removing explicit cache false (non-deterministic step) |
| modules/local/analyzedepths/main.nf | Tweaks inputs/formatting and adds versions output |
| conf/test_real.config | Adds commented example params for MAF/custom-depth mode |
| conf/modules.config | Adds config block for INPUTMAF2VCF publishing/args |
| conf/general_files_IRB.config | Formatting/alignment changes |
| bin/utils_plot.py | Adds color mapping for - mutation type |
| bin/plot_maf.py | Uses custom SBS colors for MUTTYPE plots; refactors plotting into multi-figure returns |
| bin/merge_annotation_depths.py | Drops CONTEXT column if present before joining |
| bin/deepcsa_maf2samplevcfs.py | Adds support for AM depth columns and new FORMAT fields |
| bin/create_consensus_panel.py | Drops CONTEXT column if present before numeric casts |
| bin/concat_sigprot_matrices.py | Refactors matrix saving and adds MSA matrix generation |
| assets/useful_scripts/downsample_depths.ipynb | Removed notebook |
| assets/useful_scripts/downsample.ipynb | Adds notebook for custom downsampling workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@copilot fix the comments provided ensuring that the pipeline can be executed properly |
Contributor
|
@FerriolCalvet I've opened a new pull request, #432, to work on those changes. Once the pull request is ready, I'll request review from you. |
…on, schema desc, and docs Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Fix input_maf validation, publishDir glob, cache, schema, and add MAF input docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Mandatory tasks