Fix input_maf validation, publishDir glob, cache, schema, and add MAF input docs#432
Merged
FerriolCalvet merged 3 commits intominor-fixesfrom Mar 14, 2026
Merged
Fix input_maf validation, publishDir glob, cache, schema, and add MAF input docs#432FerriolCalvet merged 3 commits intominor-fixesfrom
FerriolCalvet merged 3 commits intominor-fixesfrom
Conversation
…on, schema desc, and docs Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update input format and improve plots for deepCSA
Fix input_maf validation, publishDir glob, cache, schema, and add MAF input docs
Mar 13, 2026
FerriolCalvet
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback on the MAF input feature revealed several correctness issues: invalid publishDir globs silently dropping VCFs, disabled
cache falseon a non-deterministic process, misleading schema description, and no early validation when--input_mafis used without--use_custom_depths.Fixes
conf/modules.config:"**{vcf}"→"*.vcf"forMAF2VCFandINPUTMAF2VCF— the original pattern is not a valid glob and published nothingmodules/local/downsample/mutations/main.nf: Restorecache false— downsampling is non-deterministic; cached results across reruns are incorrect by definitionworkflows/deepcsa.nf: Add early guard that callserrorwhen--input_mafis set without--use_custom_depths true, preventing silent fallback toINPUT_CHECKnextflow_schema.json: Rewroteinput_mafdescription/help_text — removes the misleading "WILL OVERWRITE THE input.csv DATA" wording; accurately states theuse_custom_depthsdependency and that--inputis still requiredTests
tests/test_data/test_mutations.maf(minimal non-deepCSA MAF)"Should fail when --input_maf is provided without --use_custom_depths"assertingworkflow.failedand the expected error stringinput_maf+use_custom_depthspath (requires a precomputed depths table as test asset)Documentation
Added
docs/usage.mdsection "MAF file as input (alternative input mode)" covering: when to use it, required parameter combination, MAF column requirements (deepCSA-origin vs. external), example invocation, and pipeline behaviour.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.