This repository was archived by the owner on Mar 8, 2020. It is now read-only.
native: Use a intermediate bytestream to handle stream closing#24
Merged
Conversation
juanjux
approved these changes
Jun 22, 2017
smola
approved these changes
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix both #19 and #23. As can be seen at https://github.com/FasterXML/jackson-databind/blob/master/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java#L3898, the output stream is being closed by the object mapper after the value is written, causing the problem.
Surprisingly, trying to write on a closed stream doesn't generate any exception, which made the problem harder to solve.
Note that I don't know any Java, so there may be a better way to solve this, please let me know if that's the case (cc: @bzz)