refactor(validation): rely on JMail 2.2.1 for RFC 2047 encoded word r… - #719
Closed
RohanNagar wants to merge 1 commit into
Closed
refactor(validation): rely on JMail 2.2.1 for RFC 2047 encoded word r…#719RohanNagar wants to merge 1 commit into
RohanNagar wants to merge 1 commit into
Conversation
bbottema
added a commit
that referenced
this pull request
Sep 5, 2026
Retain Simple Java Mail's encoded-word guard for callers that disable general address validation. Co-authored-by: Rohan Nagar <rohannagar11@gmail.com>
Owner
|
Thanks for the update! I've included JMail 2.2.1 in 9.3.3 via 3851030, with your contribution attribution preserved. I kept Simple Java Mail's encoded-word guard because callers may intentionally pass no general address validator; relying only on JMail would regress that supported path. This PR is therefore superseded by the integrated change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ejection
Hey @bbottema 👋🏽
I just released v2.2.1 of JMail, which includes a fix for rejecting addresses that have encoded words in the local-part.
It also improves performance by up to 78% (avg time to validate
email@example.comwent from ~450ns to ~95ns).EDIT: I think one test is failing locally, haven't had time to dive into it yet.