Skip to content

(GH-17) WithIocTest case improved. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefan-lindegger merged 1 commit into from
Nov 20, 2019
Merged

(GH-17) WithIocTest case improved. #18

stefan-lindegger merged 1 commit into from
Nov 20, 2019

Conversation

@stefan-lindegger
Copy link
Member

@stefan-lindegger stefan-lindegger commented Nov 20, 2019 •
edited
Loading

Fixes #17.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #18 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #18   +/-   ##
=====================================
  Coverage       50%   50%           
=====================================
  Files            2     2           
  Lines            8     8           
  Branches         2     2           
=====================================
  Hits             4     4           
  Misses           2     2           
  Partials         2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b953de9...aa09005. Read the comment docs.

marco-bertschi
marco-bertschi approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@marco-bertschi marco-bertschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-lindegger stefan-lindegger merged commit 4ffa4ad into bbtsoftware:develop Nov 20, 2019
@stefan-lindegger stefan-lindegger deleted the feature/GH-17 branch November 20, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianbumann christianbumann Awaiting requested review from christianbumann

@georgesgoetz georgesgoetz Awaiting requested review from georgesgoetz

@pascalberger pascalberger Awaiting requested review from pascalberger

@silanosa silanosa Awaiting requested review from silanosa

@Speeedy01 Speeedy01 Awaiting requested review from Speeedy01

1 more reviewer

@marco-bertschi marco-bertschi marco-bertschi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve WithIocTest case

2 participants

@stefan-lindegger @marco-bertschi