build: point the submodule at the encoder's main - #2000
Merged
johan-bell merged 1 commit intoSep 3, 2026
Conversation
#200 is merged, so the player packages the app builds against live on the encoder's main branch. The pin was ff0f6c9 and `branch` still named the integration branch — which the merge deleted, leaving the pinned commit unreachable and every fresh checkout one GitHub garbage collection away from failing to clone it. Both now point at main: 33e0ecf, the squash of #200.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#200 is merged (
33e0ecfonbccsa/luminary-media-convertmain), so the player packages the app builds against now live on the encoder'smain.Two things needed changing, and both were urgent rather than tidy-up:
ff0f6c9, which existed only onluminary-1897-encrypted-hls. That branch was auto-deleted when APP: Add query caching for heavy database queries #200 merged, so the pin was left pointing at an unreachable commit — a freshgit clone --recurse-submoduleswould keep working only until GitHub garbage-collects it, then fail outright..gitmodulesstill named the integration branch, sogit submodule update --remotehad nothing to track.Both now point at
main/33e0ecf.Nothing else changes:
33e0ecfis the squash of exactly the commitsff0f6c9was an ancestor of, plus #226, #227 and #229, so the app builds against the same player sources it did before — with the window/server crash fix and the work-directory reclamation included.