Skip to content

imp: restart node right after dumped or before exit due to error #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

imp: restart node right after dumped or before exit due to error #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5337c70
early restart node after dump
0xbcdev Jul 4, 2024
1244fbd
restart service before exit if error occurs
0xbcdev Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions cmd/node/dump_snapshot/dump_snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@ func GetDumpSnapshotCmd() *cobra.Command {
defer execCleanup()

var stoppedService bool

defer func() {
if exitWithError && stoppedService {
fmt.Println("INF: restarting service before exit due to error")
ec := utils.LaunchApp("sudo", []string{"systemctl", "restart", serviceName})
if ec != 0 {
utils.PrintlnStdErr("ERR: failed to restart service", serviceName)
}
}
}()

go func() {
time.Sleep(maxDuration)
utils.PrintlnStdErr("ERR: timeout")
Expand Down Expand Up @@ -239,6 +250,18 @@ func GetDumpSnapshotCmd() *cobra.Command {
_ = os.Remove(outputFileName)
})

if !noService {
// restart the service
fmt.Println("INF: restarting service")
ec = utils.LaunchApp("sudo", []string{"systemctl", "restart", serviceName})
if ec != 0 {
utils.PrintlnStdErr("ERR: failed to restart service")
exitWithError = true
return
}
time.Sleep(15 * time.Second)
}

fmt.Println("INF: restoring into", dumpHomeDir)
ec = utils.LaunchApp(binary, []string{
"snapshots", "load", outputFileName,
Expand Down Expand Up @@ -292,15 +315,6 @@ func GetDumpSnapshotCmd() *cobra.Command {
registeredCleanup = append(registeredCleanup, func() {
_ = launchCmd.Process.Kill()
})
} else {
fmt.Println("INF: restarting service")
ec = utils.LaunchApp("sudo", []string{"systemctl", "restart", serviceName})
if ec != 0 {
utils.PrintlnStdErr("ERR: failed to restart service")
exitWithError = true
return
}
time.Sleep(5 * time.Second)
}

rpc, err := types.ReadNodeRpcFromConfigToml(path.Join(nodeHomeDirectory, "config", "config.toml"))
Expand Down