fix off-by-4 header length guard in NotationData.verifyData - #2346
Closed
rootvector2 wants to merge 1 commit into
Closed
fix off-by-4 header length guard in NotationData.verifyData#2346rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the patch. Merged! |
hubot
pushed a commit
that referenced
this pull request
Jul 9, 2026
… OpenPGP notation subpacket header is 8 octets, so a body declaring more name/value than it carried passed the check and overran in getNotationName/getNotationValueBytes; now counts the full header, relates to github #2346.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotationData.verifyDatacounts onlynameLength + valueLength + 4against the body length while its own header is 8 octets (flags[4] || nameLength[2] || valueLength[2]), so a crafted critical notation subpacket that declares more name/value data than the body carries slips past the guard and then throwsArrayIndexOutOfBoundsExceptionfromgetNotationName()/getNotationValueBytes()on the signature-verify path instead of a clean rejection; counting the full header rejects the short body at parse and completes the siblingFeatures/TrustSignature/SignatureTarget/RevocationKey/RevocationReasontruncation guards; spotted while fuzzing the signature-subpacket parser.