Skip to content

DBC22-6032: reordering advisory/bulletin under index page - #1295

Merged
wmuldergov merged 3 commits into
mainfrom
feature/DBC22-6032
Apr 22, 2026
Merged

DBC22-6032: reordering advisory/bulletin under index page#1295
wmuldergov merged 3 commits into
mainfrom
feature/DBC22-6032

Conversation

@bcgov-brwang

@bcgov-brwang bcgov-brwang commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Login to wagtail cms admin page.
  2. From left panel, click on Advisories/Bulletins.
  3. Verify if Advisory/Bulletin can be created if Advisory/Bulletin index page does not exist. The user can't see "Add Advisory"/"Add Bulletin" button if index page not created.
  4. From left panel Pages->Add Child-> to Create AvdisoryIndexPage/BulletinIndexPage before Advisory/Bulletin creation.
  5. Go to Advisories/Bulletins to create new Advisory/Bulletin.
  6. Go to Pages-> Advisory Index Page/Bulletin Index Page.
  7. Click on three dot icon "Sort menu order" for existing Advisories/Bulletins.
  8. Drag/drop the items up/down you would like to order.
  9. Go to frontend to verify if the Advisories/Bulletins order can be updated based on the drag/drop order from the wagtail backend.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@bcgov-brwang
bcgov-brwang requested a review from wmuldergov April 14, 2026 15:23
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@bcgov-brwang bcgov-brwang changed the title Feature/dbc22 6032 DBC22-6032: reordering advisory/bulletin under index page Apr 14, 2026
@bcgov-brwang
bcgov-brwang marked this pull request as ready for review April 14, 2026 20:12
DBC22-6032: added test cases for new functions

DBC22-6032: reparent orphan advisories and bulletins

DBC22-6032: added test cases for new functions

@wmuldergov wmuldergov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in dev

@wmuldergov
wmuldergov merged commit 03d72bc into main Apr 22, 2026
3 of 4 checks passed
@wmuldergov
wmuldergov deleted the feature/DBC22-6032 branch April 22, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants