Skip to content

DBC22-5926: Route save modal fixes from regression - #1307

Merged
bcgov-brwang merged 1 commit into
mainfrom
bugfix/DBC22-5926
Apr 27, 2026
Merged

DBC22-5926: Route save modal fixes from regression#1307
bcgov-brwang merged 1 commit into
mainfrom
bugfix/DBC22-5926

Conversation

@minORC

@minORC minORC commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

📝 Submitter: Min Ji Choi

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests N/A
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? No

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Login to account
  2. Enter a route search
  3. Click on save to save the searched route
  4. Verify that the save route modal is not hidden by the header and that the route nickname tooltip is styled correctly (see screenshot in ticket)

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@minORC
minORC force-pushed the bugfix/DBC22-5926 branch from 3da2286 to a958428 Compare April 24, 2026 17:31
@minORC
minORC requested a review from bcgov-brwang April 24, 2026 22:41
@minORC
minORC marked this pull request as ready for review April 24, 2026 22:41
@minORC
minORC force-pushed the bugfix/DBC22-5926 branch from a958428 to 380d1ca Compare April 24, 2026 22:43
@minORC minORC changed the title DBC22-5926: Moved route saving modal lower to not be hidden by header navbar on mobile. DBC22-5926: Route save modal fixes from regression Apr 24, 2026
@minORC
minORC force-pushed the bugfix/DBC22-5926 branch from 380d1ca to a63fd23 Compare April 27, 2026 18:44
@bcgov-brwang
bcgov-brwang merged commit fd24669 into main Apr 27, 2026
3 of 4 checks passed
@bcgov-brwang
bcgov-brwang deleted the bugfix/DBC22-5926 branch April 27, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants