Skip to content

DBC22-6813: notify when planned events become active - #1389

Merged
ray-oxd merged 1 commit into
mainfrom
bugfix/DBC22-6813
Jul 6, 2026
Merged

DBC22-6813: notify when planned events become active#1389
ray-oxd merged 1 commit into
mainfrom
bugfix/DBC22-6813

Conversation

@ray-oxd

@ray-oxd ray-oxd commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Create a saved route with notifications enabled for all event types.
  2. Create a planned event along the route that is not yet active.
  3. Wait for the event to become active (or simulate via populate task).
  4. Verify the user receives a route notification email when the event activates.
  5. Run python manage.py test apps.event.tests.test_event_populate.TestEventModel.test_planned_event_activation_triggers_update

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@ray-oxd
ray-oxd force-pushed the bugfix/DBC22-6813 branch from 0f8fbe3 to 94464c6 Compare July 3, 2026 22:29
Return True from populate when a future delay event transitions to an
active display category so route notification emails are queued.
@ray-oxd
ray-oxd force-pushed the bugfix/DBC22-6813 branch from 94464c6 to 9317ab5 Compare July 3, 2026 22:29
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
63.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ray-oxd
ray-oxd merged commit 1f52bc7 into main Jul 6, 2026
7 of 8 checks passed
@ray-oxd
ray-oxd deleted the bugfix/DBC22-6813 branch July 6, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant