noc_expiry job - Add NOC_EXPIRED event#670
Closed
shaangill025 wants to merge 2 commits intobcgov:mainfrom
Closed
Conversation
Contributor
Author
|
Failing unit test will work after merge of #663. |
kris-daxiom
reviewed
Apr 8, 2025
Contributor
kris-daxiom
left a comment
kris-daxiom
left a comment
There was a problem hiding this comment.
Once the other PR is merged, update the strr-api version and include the lockfile here
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
shaangill025
force-pushed
the
fix_26983_followup
branch
from
8fea4a9 to
a34cfc2
Compare
|
Contributor
Author
|
@kris-daxiom This should be ready now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
#663 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License