API - NOC Events & Created Date Update by shaangill025 · Pull Request #663 · bcgov/STRR

shaangill025 · 2025-04-04T18:07:15Z

Issue:

API - Missing Events entity#26983

Description of changes:
Also added an is-assignee check endpoint which is required for assign and unassign workflow in Examiner UI.

(Verified that time being shown is in Pacific even though system time is in EST)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

kris-daxiom · 2025-04-04T22:26:34Z

    event_name = db.Column(db.Enum(EventName), nullable=False)
    details = db.Column(db.String, nullable=True)
-    created_date = db.Column(db.DateTime, nullable=False, server_default=text("(NOW())"))
+    created_date = db.Column(db.DateTime(timezone=True), nullable=False, server_default=text("(NOW())"))


Is this getting stored in UTC? Looks like it may be using the tz of db server

It is getting stored in UTC but it doesn't have the offset as it timezone aware which is causing issues when converting it in the UI.

kris-daxiom · 2025-04-04T22:28:01Z

    start_date = db.Column(db.DateTime(timezone=True), nullable=False)
    end_date = db.Column(db.DateTime(timezone=True), nullable=False)
-    creation_date = db.Column(db.DateTime, nullable=False, server_default=text("(NOW())"))
+    creation_date = db.Column(db.DateTime(timezone=True), nullable=False, server_default=text("(NOW())"))


I think I need to remove this column because these are present in the base model

kris-daxiom · 2025-04-04T22:30:21Z

        application.status = Application.Status.NOC_PENDING
        application.save()
        EmailService.send_notice_of_consideration_for_application(application)
+        reviewer = UserService.get_or_create_user_in_context()


this is already done at the resource level. Passing reviewer_id will avoid the extra look up

kris-daxiom · 2025-04-04T22:31:33Z

@kris-daxiom This is ready for review. The unit test is failing because:

STRR/jobs/noc_expiry/pyproject.toml

Line 22 in eca06dc

strr-api = {git = "https://github.com/bcgov/STRR.git", rev = "main", subdirectory = "strr-api"}

Locally, I tested with strr-api = {git = "https://github.com/shaangill025/STRR.git", rev = "fix_26983", subdirectory = "strr-api"}

You will have merge the api code first and then update the api version in the job and commit that poetry lock file as well

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

sonarqubecloud · 2025-04-08T15:11:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

shaangill025 · 2025-04-08T15:16:59Z

You will have merge the api code first and then update the api version in the job and commit that poetry lock file as well

@kris-daxiom #670

* feat: Registration Todos (#668) * feat: Registration Todos * Added Expired to the status array * API - NOC Events & Created Date Update (#663) * 26983 - events & timestamp type update Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - lint fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - nox_expiry unit test Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - lint fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - cleanup Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - cleanup Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - add UnitTestConfig to noc_expiry job conftest Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - isort fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - run mode fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - run mode fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - check assignee, feedback changes, remove noc_expiry job changes Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - lint fixes Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> --------- Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * noc expiry timezone related fix & noc events (#664) Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * Fix scroll in NOC To Do (#667) * Fix scroll in NOC To Do * ci-cd (#671) * indent (#673) * add quote (#674) * fix: Adding run script (#675) --------- Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> Co-authored-by: Shaanjot Gill <shaangill025@users.noreply.github.com> Co-authored-by: Dima K <dima1086@hotmail.com> Co-authored-by: Avni Salhotra <132402145+avni-work@users.noreply.github.com>

shaangill025 requested review from kris-daxiom and thorwolpert as code owners April 4, 2025 18:07

shaangill025 self-assigned this Apr 4, 2025

This comment was marked as outdated.

Sign in to view

kris-daxiom approved these changes Apr 4, 2025

View reviewed changes

kris-daxiom reviewed Apr 4, 2025

View reviewed changes

shaangill025 added 11 commits April 8, 2025 08:03

26983 - events & timestamp type update

26606cf

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - lint fix

82e192e

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - nox_expiry unit test

0971d37

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - lint fix

fd096b1

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - cleanup

91b3961

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - cleanup

f9c4320

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - add UnitTestConfig to noc_expiry job conftest

d611aed

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - isort fix

d0001b5

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - run mode fix

816a5cc

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - run mode fix

9b4c504

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

26983 - check assignee, feedback changes, remove noc_expiry job changes

1c2d021

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

shaangill025 force-pushed the fix_26983 branch from 4667f27 to 1c2d021 Compare April 8, 2025 15:03

26983 - lint fixes

515996e

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

shaangill025 mentioned this pull request Apr 8, 2025

noc_expiry job - Add NOC_EXPIRED event #670

Closed

shaangill025 mentioned this pull request Apr 8, 2025

Examiner UI - Application Details - Assign and Unassign #669

Merged

kris-daxiom approved these changes Apr 8, 2025

View reviewed changes

shaangill025 merged commit 9a127aa into bcgov:main Apr 8, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API - NOC Events & Created Date Update#663

API - NOC Events & Created Date Update#663
shaangill025 merged 12 commits intobcgov:mainfrom
shaangill025:fix_26983

shaangill025 commented Apr 4, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

kris-daxiom Apr 4, 2025

Uh oh!

shaangill025 Apr 8, 2025

Uh oh!

kris-daxiom Apr 4, 2025

Uh oh!

kris-daxiom Apr 4, 2025

Uh oh!

shaangill025 Apr 8, 2025

Uh oh!

kris-daxiom commented Apr 4, 2025

Uh oh!

sonarqubecloud Bot commented Apr 8, 2025

Uh oh!

shaangill025 commented Apr 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shaangill025 commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

kris-daxiom Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

shaangill025 Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

kris-daxiom Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

kris-daxiom Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

shaangill025 Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

kris-daxiom commented Apr 4, 2025

Uh oh!

sonarqubecloud Bot commented Apr 8, 2025

Quality Gate passed

Uh oh!

shaangill025 commented Apr 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shaangill025 commented Apr 4, 2025 •

edited

Loading